Adding back deleted docker-compose.yml #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
这是来自QQ邮箱的假期自动回复邮件。
您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。
|
Apply Sweep Rules to your PR?
|
|
Hey, thanks for the PR, a lot of people have been asking for this but honestly I'm not good with docker so I was not able to fix it myself, really appreciate your PR. I think we should first merge it to the dev branch and then to main so all the changes in the dev branch are on main. I will be changing the bran on this PR to the dev branch and then merging it and also merging dev to main afterward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include:
I'm not sure why this
docker-compose.ymlwas deleted in the first place. Nearly half of the instructions in the readme for this repo rely on this file being there.Essentially, it's just another way to start up the container using
docker compose. This makes the container much more usable for power users, as they'd be able to configure volumes much easier. Also, instead of having to remember the whole complicateddocker container run --rm -d -p 8501:8501 -e STREAMLIT_SERVER_HEADLESS=true -e "WEBUI_SCRIPT=webui_streamlit.py" -e "VALIDATE_MODELS=false" -v "${PWD}/outputs:/sd/outputs" --gpus all tukirito/sygil-webui:latestcommand, it's as simple as runningdocker compose startorup, since all of the configs are in the compose file, you wouldn't need anything else. The compose file has been tested and runs without any issues. The readme instructions can stay mostly as is.Additionally, as mentioned before, the readme instructions rely heavily on docker compose. If the repo creators wish to not include docker compose, then it should all be omitted from the readme, as it makes this extremely confusing for any user.
Closes: # (issue)
Checklist:
dev